SteNicholas commented on code in PR #2482: URL: https://github.com/apache/celeborn/pull/2482#discussion_r1590945100
########## README.md: ########## @@ -301,6 +301,10 @@ spark.sql.adaptive.skewJoin.enabled true spark.shuffle.sort.io.plugin.class org.apache.spark.shuffle.celeborn.CelebornShuffleDataIO # Required Spark version >= 3.4.0, highly recommended to disable spark.dynamicAllocation.shuffleTracking.enabled false + +# Support ShuffleManager defined in user jar +# Required Spark version >= 4.0.0, highly recommended to false for ShuffleManager in user-defined jar +spark.executor.userClassPathFirst=false Review Comment: @cfmcgrady, other highly recommended options like `spark.dynamicAllocation.shuffleTracking.enabled` is also mentioned in startup guideline, which only remind the users to pay attention to these config options. What's inappropriate from a user's perspective? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
