SteNicholas commented on code in PR #2482:
URL: https://github.com/apache/celeborn/pull/2482#discussion_r1590949399
##########
client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkShuffleManager.java:
##########
@@ -420,6 +424,20 @@ private int executorCores(SparkConf conf) {
}
}
+ private void checkUserClassPathFirst() {
+ if ((Boolean) conf.get(package$.MODULE$.EXECUTOR_USER_CLASS_PATH_FIRST()))
{
Review Comment:
@cfmcgrady, this has already respected the config
`celeborn.client.spark.shuffle.fallback.policy` because `getReader/getWriter`
is invoked after `registerShuffle`. Meanwhile, `registerShuffle` could not
distinguish the problem case via classloader. Therefore, we could not perform
the check within `CelebornShuffleFallbackPolicyRunner`. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
