mridulm commented on code in PR #2482:
URL: https://github.com/apache/celeborn/pull/2482#discussion_r1591934586
##########
client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkShuffleManager.java:
##########
@@ -254,6 +257,20 @@ private int executorCores(SparkConf conf) {
}
}
+ private void checkUserClassPathFirst() {
+ if ((Boolean) conf.get(package$.MODULE$.EXECUTOR_USER_CLASS_PATH_FIRST()))
{
Review Comment:
Emit log message only when classloaders are different ? (same for the other
classes as well)
Something like this perhaps ... thoughts ?
```suggestion
if ((Boolean)
conf.get(package$.MODULE$.EXECUTOR_USER_CLASS_PATH_FIRST()) &&
!Objects.equals(getClass().getClassLoader(),
conf.getClass().getClassLoader())
) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
