SteNicholas commented on code in PR #2482:
URL: https://github.com/apache/celeborn/pull/2482#discussion_r1592423130
##########
client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkShuffleManager.java:
##########
@@ -254,6 +257,20 @@ private int executorCores(SparkConf conf) {
}
}
+ private void checkUserClassPathFirst() {
+ if ((Boolean) conf.get(package$.MODULE$.EXECUTOR_USER_CLASS_PATH_FIRST()))
{
Review Comment:
@mridulm, when classloaders are different, `handle instanceof
CelebornShuffleHandle` returns false, right? IMO, the validation of
classloaders is unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
