turboFei commented on code in PR #2495:
URL: https://github.com/apache/celeborn/pull/2495#discussion_r1595007307
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/http/api/ApiMasterResource.scala:
##########
@@ -102,11 +88,26 @@ class ApiMasterResource extends ApiRequestContext {
responseCode = "200",
content = Array(new Content(
mediaType = MediaType.TEXT_PLAIN)),
- description = "List all worker event infos of the master.")
+ description =
+ "Excluded workers of the master add or remove the worker manually given
worker id. The parameter add or remove specifies the excluded workers to add or
remove, which value is separated by commas.")
@POST
- def excludeWorkers(
- @QueryParam("ADD") addWorkers: String,
- @QueryParam("REMOVE") removeWorkers: String): String = {
+ def exclude(
+ @FormParam("add") addWorkers: String,
+ @FormParam("remove") removeWorkers: String): String = {
Review Comment:
ok, I just think that it is a break change for this API.
Has this api been released before? If that, I think we need to mention it in
migration user guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
