ChenYi015 commented on PR #2499: URL: https://github.com/apache/celeborn/pull/2499#issuecomment-2107096379
> it's good if only about indention, but I would like to avoid such user-facing breaking changes unless you have good reasons. > > ``` > - Rename `imagePullSecrets` value to `image.pullSecrets` > - Rename `masterReplicas` to `replicaCount.master` > - Rename `workerReplicas` to `replicaCount.worker` > ``` Maybe we can mark these fields as deprecated and provide back-forward compatibility in helm charts, how do you think about it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
