ChenYi015 opened a new pull request, #2506:
URL: https://github.com/apache/celeborn/pull/2506

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] 
Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a 
faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   - Move all  the master/worker resource manifests to 
`charts/celeborn/templates/master` and `charts/celeborn/templates/worker` 
directories, respectively.
   - Comment license with helm template syntax
   - It's better that all resource names are defined once in `_helpers.tml` and 
refered in other files.
   - Use [helm-docs]() to generate helm chart README file.
   - Add .helmignore file to specify patterns for files and directories that 
should be ignored when packaging the chart.
   
   ### Why are the changes needed?
   
   As dicussed in #2499 , I will break it down into serveral smaller dedicated 
patches.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Local test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to