waitinfuture commented on code in PR #2524:
URL: https://github.com/apache/celeborn/pull/2524#discussion_r1608467976
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorter.java:
##########
@@ -629,11 +629,19 @@ public void sort() throws InterruptedException {
for (ShuffleBlockInfo blockInfo : originShuffleBlocks) {
long offset = blockInfo.offset;
long length = blockInfo.length;
- ShuffleBlockInfo sortedBlock = new ShuffleBlockInfo();
- sortedBlock.offset = fileIndex;
- sortedBlock.length = length;
- sortedShuffleBlocks.add(sortedBlock);
fileIndex += transferBlock(offset, length);
Review Comment:
I think we should put `fileIndex += transferBlock(offset, length);` below
the `if-else` block, because we need make sure the `offset` of the first
`sortedBlock` equals to `0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
