s0nskar commented on code in PR #2524:
URL: https://github.com/apache/celeborn/pull/2524#discussion_r1608702703
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorter.java:
##########
@@ -629,10 +629,17 @@ public void sort() throws InterruptedException {
for (ShuffleBlockInfo blockInfo : originShuffleBlocks) {
long offset = blockInfo.offset;
long length = blockInfo.length;
- ShuffleBlockInfo sortedBlock = new ShuffleBlockInfo();
- sortedBlock.offset = fileIndex;
- sortedBlock.length = length;
- sortedShuffleBlocks.add(sortedBlock);
+ // combine multiple `ShuffleBlockInfo` into a single
`ShuffleBlockInfo` of size
+ // less than `shuffleChunkSize`
+ if (!sortedShuffleBlocks.isEmpty() &&
+ sortedShuffleBlocks.get(sortedShuffleBlocks.size() - 1).length
+ length <= shuffleChunkSize) {
Review Comment:
@waitinfuture Just wanted to double check if `<=` condition would be fine
here, or `shuffleChunkSize` is exclusive upperBound.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
