RexXiong commented on code in PR #2535:
URL: https://github.com/apache/celeborn/pull/2535#discussion_r1624164076
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -436,6 +446,12 @@ public void updateWorkerEventMeta(int
workerEventTypeValue, List<WorkerInfo> wor
}
}
+ public void updateMetaByReportWorkerDecommission(List<WorkerInfo> workers) {
+ synchronized (this.workers) {
+ decommissionWorkers.addAll(workers);
Review Comment:
> It seems that we should return decommissionWorkers to the client through
heartbeat, but do we need to distinguish between shutdown and decommission on
the client side?
Currently, the client doesn't need to know that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
