SteNicholas commented on code in PR #2535:
URL: https://github.com/apache/celeborn/pull/2535#discussion_r1624428884
##########
METRICS.md:
##########
@@ -147,6 +148,7 @@ Here is an example of Grafana dashboard importing.
| PotentialConsumeSpeed | worker |
This value means speed of potential consumption for congestion control.
|
| UserProduceSpeed | worker |
This value means speed of user production for congestion control.
|
| WorkerConsumeSpeed | worker |
This value means speed of worker consumption for congestion control.
|
+| isDecommissioningWorker | worker |
Show if the worker is during the process of decommissioning.
|
Review Comment:
Why introduce `isDecommissioningWorker` metric? I don't think users would
pay attention to whether the worker is decomissioning after decomissioning
worker. Meanwhile, `isExiting` is better than this metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
