SteNicholas opened a new pull request, #2555:
URL: https://github.com/apache/celeborn/pull/2555
### What changes were proposed in this pull request?
- Fix `WARNING` of error prone.
- Disable `JdkObsolete`, `MutableConstantField` and
`UnnecessaryParentheses`.
### Why are the changes needed?
There are many `WARNING` generated by error prone. We should follow the
suggestion of error prone.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual test.
```
$ mvn clean install -Pjdk-8 -DskipTests -Dcheckstyle.skip=true
-Drat.skip=true -Dspotless.check.skip=true|grep WARNING
[WARNING]
[WARNING] Some problems were encountered while building the effective model
for org.apache.celeborn:celeborn-common_2.12:jar:0.6.0-SNAPSHOT
[WARNING] 'artifactId' contains an expression but should be a constant. @
org.apache.celeborn:celeborn-common_${scala.binary.version}:${project.version},
/Users/nicholas/Github/celeborn/common/pom.xml, line 28, column 15
[WARNING] 'artifactId' contains an expression but should be a constant. @
org.apache.celeborn:celeborn-parent_${scala.binary.version}:${project.version},
/Users/nicholas/Github/celeborn/pom.xml, line 27, column 15
[WARNING] 'version' contains an expression but should be a constant. @
org.apache.celeborn:celeborn-parent_${scala.binary.version}:${project.version},
/Users/nicholas/Github/celeborn/pom.xml, line 28, column 12
[WARNING]
[WARNING] Some problems were encountered while building the effective model
for org.apache.celeborn:celeborn-client_2.12:jar:0.6.0-SNAPSHOT
[WARNING] 'artifactId' contains an expression but should be a constant. @
org.apache.celeborn:celeborn-client_${scala.binary.version}:${project.version},
/Users/nicholas/Github/celeborn/client/pom.xml, line 28, column 15
[WARNING]
[WARNING] Some problems were encountered while building the effective model
for org.apache.celeborn:celeborn-service_2.12:jar:0.6.0-SNAPSHOT
[WARNING] 'artifactId' contains an expression but should be a constant. @
org.apache.celeborn:celeborn-service_${scala.binary.version}:${project.version},
/Users/nicholas/Github/celeborn/service/pom.xml, line 28, column 15
[WARNING]
[WARNING] Some problems were encountered while building the effective model
for org.apache.celeborn:celeborn-master_2.12:jar:0.6.0-SNAPSHOT
[WARNING] 'artifactId' contains an expression but should be a constant. @
org.apache.celeborn:celeborn-master_${scala.binary.version}:${project.version},
/Users/nicholas/Github/celeborn/master/pom.xml, line 26, column 15
[WARNING]
[WARNING] Some problems were encountered while building the effective model
for org.apache.celeborn:celeborn-worker_2.12:jar:0.6.0-SNAPSHOT
[WARNING] 'artifactId' contains an expression but should be a constant. @
org.apache.celeborn:celeborn-worker_${scala.binary.version}:${project.version},
/Users/nicholas/Github/celeborn/worker/pom.xml, line 26, column 15
[WARNING]
[WARNING] Some problems were encountered while building the effective model
for org.apache.celeborn:celeborn-web_2.12:pom:0.6.0-SNAPSHOT
[WARNING] 'artifactId' contains an expression but should be a constant. @
org.apache.celeborn:celeborn-web_${scala.binary.version}:${project.version},
/Users/nicholas/Github/celeborn/web/pom.xml, line 26, column 15
[WARNING]
[WARNING] Some problems were encountered while building the effective model
for org.apache.celeborn:celeborn-parent_2.12:pom:0.6.0-SNAPSHOT
[WARNING] 'artifactId' contains an expression but should be a constant. @
org.apache.celeborn:celeborn-parent_${scala.binary.version}:${project.version},
/Users/nicholas/Github/celeborn/pom.xml, line 27, column 15
[WARNING] 'version' contains an expression but should be a constant. @
org.apache.celeborn:celeborn-parent_${scala.binary.version}:${project.version},
/Users/nicholas/Github/celeborn/pom.xml, line 28, column 12
[WARNING]
[WARNING] It is highly recommended to fix these problems because they
threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support
building such malformed projects.
[WARNING]
[WARNING] JAR will be empty - no content was marked for inclusion!
[WARNING]
/Users/nicholas/Github/celeborn/common/src/main/java/org/apache/celeborn/common/unsafe/Platform.java:28:15:
Unsafe is internal proprietary API and may be removed in a future release
[WARNING]
/Users/nicholas/Github/celeborn/common/src/main/java/org/apache/celeborn/common/unsafe/Platform.java:33:23:
Unsafe is internal proprietary API and may be removed in a future release
[WARNING]
/Users/nicholas/Github/celeborn/common/src/main/java/org/apache/celeborn/common/unsafe/Platform.java:313:12:
Unsafe is internal proprietary API and may be removed in a future release
[WARNING]
/Users/nicholas/Github/celeborn/common/src/main/java/org/apache/celeborn/common/unsafe/Platform.java:315:26:
Unsafe is internal proprietary API and may be removed in a future release
[WARNING]
/Users/nicholas/Github/celeborn/common/src/main/java/org/apache/celeborn/common/unsafe/Platform.java:317:24:
Unsafe is internal proprietary API and may be removed in a future release
[WARNING] unknown enum constant Level.FULL
[WARNING] Unexpected javac output: warning: unknown enum constant Level.FULL
[WARNING] unknown enum constant Level.FULL
[WARNING] JAR will be empty - no content was marked for inclusion!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
