mridulm commented on code in PR #2555:
URL: https://github.com/apache/celeborn/pull/2555#discussion_r1639192185
##########
common/src/test/java/org/apache/celeborn/common/network/sasl/SaslTestBase.java:
##########
@@ -96,9 +96,7 @@ void authHelper(
TimeUnit.MILLISECONDS.sleep(10);
}
}
- if (error != null) {
- throw error;
- }
+ assertNull(error);
Review Comment:
Oh wait, `Throwables.getStackTraceAsString` will serialize the 'cause' as
well, heh ...
The intent here though is to throw the actual exception which was raised -
not NPE :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
