SteNicholas commented on code in PR #2553:
URL: https://github.com/apache/celeborn/pull/2553#discussion_r1634848690
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -232,8 +232,7 @@ final private[worker] class StorageManager(conf:
CelebornConf, workerSource: Abs
reloadAndCleanFileInfos(this.db)
} catch {
case e: Exception =>
- logError("Init level DB failed:", e)
- this.db = null
+ throw new IllegalStateException("Enable workerGracefulShutdown but
failed to initialize db for recovery", e)
Review Comment:
```suggestion
throw new IllegalStateException("Failed to initialize db for
recovery during graceful worker shutdown.", e)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
