RexXiong commented on code in PR #2553:
URL: https://github.com/apache/celeborn/pull/2553#discussion_r1634598084
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -574,7 +574,7 @@ final private[worker] class StorageManager(conf:
CelebornConf, workerSource: Abs
}
if (workerGracefulShutdown) {
committedFileInfos.remove(shuffleKey)
- if (cleanDB) {
+ if (cleanDB && null != db) {
Review Comment:
If workerGracefulShutdown enabled, IMO we need ensure db is not null. So if
initDB fail, we need fail the process.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
