FMX commented on code in PR #2557:
URL: https://github.com/apache/celeborn/pull/2557#discussion_r1639452880
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -723,13 +728,14 @@ private[celeborn] class Worker(
removeAppActiveConnection(applicationId)
secretRegistry.unregister(applicationId)
}
- logInfo(s"Cleaned up expired shuffle $shuffleKey")
}
+ logInfo(s"Cleaned up expired shuffle keys $cleanShuffleKeys")
partitionsSorter.cleanup(expiredShuffleKeys)
fetchHandler.cleanupExpiredShuffleKey(expiredShuffleKeys)
threadPool.execute(new Runnable {
override def run(): Unit =
storageManager.cleanupExpiredShuffleKey(expiredShuffleKeys)
Review Comment:
The most time-consuming part of cleaning expired shuffles is here. Recording
this time would be meaningful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
