FMX commented on code in PR #2557:
URL: https://github.com/apache/celeborn/pull/2557#discussion_r1639542459
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -723,12 +726,17 @@ private[celeborn] class Worker(
removeAppActiveConnection(applicationId)
secretRegistry.unregister(applicationId)
}
- logInfo(s"Cleaned up expired shuffle $shuffleKey")
}
+ val cleanShuffleKeys = expiredShuffleKeys.asScala.mkString(",")
+ logInfo(s"Cleaned up expired shuffle keys $cleanShuffleKeys from clean
task queue (size: ${cleanTaskQueue.size()})")
partitionsSorter.cleanup(expiredShuffleKeys)
fetchHandler.cleanupExpiredShuffleKey(expiredShuffleKeys)
threadPool.execute(new Runnable {
- override def run(): Unit =
storageManager.cleanupExpiredShuffleKey(expiredShuffleKeys)
+ override def run(): Unit = {
+
workerSource.startTimer(WorkerSource.CLEAN_EXPIRED_SHUFFLE_KEYS_TIME,
cleanShuffleKeys)
+ storageManager.cleanupExpiredShuffleKey(expiredShuffleKeys)
Review Comment:
storageManager.cleanupExpiredShuffleKey should not pass this entire
expiredShuffleKeys. It should pass the shufflekey to improve clean up speed.
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -723,12 +726,17 @@ private[celeborn] class Worker(
removeAppActiveConnection(applicationId)
secretRegistry.unregister(applicationId)
}
- logInfo(s"Cleaned up expired shuffle $shuffleKey")
}
+ val cleanShuffleKeys = expiredShuffleKeys.asScala.mkString(",")
Review Comment:
Not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
