s0nskar opened a new pull request, #2629:
URL: https://github.com/apache/celeborn/pull/2629
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Proposing to add a master endpoint resolver, which makes the master
endpoints discovery extensible and now users can create and pass different
types of resolver according to their need.
This is first draft of the PR. Wanted to get community feedback around this
before working on this further.
### Why are the changes needed?
Currently celeborn support passing master endpoints by these celeborn
configs "
celeborn.master.endpoints" and "celeborn.master.internal.endpoints" and the
allowed pattern for these configs `<host1>:<port1>[,<host2>:<port2>]*`. Worker
and Client both use above configs to connect with master.
The problem with this approach is that currently it takes static host or IP
or domain address which can change over time for a long running worker or
client. Ex – Master node going down, domain UUID changed. In our infra this
discovery is done by a passing a service group which watch the active nodes
actively but there is no way to make it work with Celeborn.
### Does this PR introduce _any_ user-facing change?
Default behaviour will remain same but user can now pass their own master
endpoint resolver.
### How was this patch tested?
Working on testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
