s0nskar commented on code in PR #2629:
URL: https://github.com/apache/celeborn/pull/2629#discussion_r1679298172
##########
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala:
##########
@@ -571,6 +571,21 @@ object Utils extends Logging {
// scalastyle:on classforname
}
+ def instantiateMasterEndpointResolver[T](
+ className: String,
+ conf: CelebornConf,
+ isWorker: Boolean): T = {
+ try {
+ val cls = classForName(className)
+ cls.getConstructor(classOf[CelebornConf], java.lang.Boolean.TYPE)
+ .newInstance(conf, java.lang.Boolean.valueOf(isWorker))
+ .asInstanceOf[T]
Review Comment:
LGTM, suggestion is missing the import so not committing from UI. Will fix
this in the next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
