mridulm commented on code in PR #2555:
URL: https://github.com/apache/celeborn/pull/2555#discussion_r1680353116
##########
service/src/main/java/org/apache/celeborn/server/common/service/store/db/DbServiceManagerImpl.java:
##########
@@ -61,6 +61,7 @@ public DbServiceManagerImpl(CelebornConf celebornConf,
ConfigService configServe
this.clusterId = createCluster(getClusterInfoFromEnv());
}
+ @SuppressWarnings("JavaUtilDate")
Review Comment:
`Instant` and `LocalDate` is not directly handled by apache ibatis, is it ?
I am not very confident - but given this is used in that context, we have to
ensure it is supported (else we will end up writing type handler, etc ... I
dont think it is worth that).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
