mridulm commented on code in PR #2555:
URL: https://github.com/apache/celeborn/pull/2555#discussion_r1680344215
##########
client/src/main/java/org/apache/celeborn/client/read/LocalPartitionReader.java:
##########
@@ -51,7 +51,7 @@
public class LocalPartitionReader implements PartitionReader {
private static final Logger logger =
LoggerFactory.getLogger(LocalPartitionReader.class);
- private static volatile ThreadPoolExecutor readLocalShufflePool;
+ private volatile ThreadPoolExecutor readLocalShufflePool;
Review Comment:
That is a reasonable recommandation when sufficient care is not taken to
address the issues.
Our existing code is doing the right thing by making sure it is initialized
in a safe manner the first time any instance of the class is created
Also note that the current change is a regression - for each instance of
`LocalPartitionReader` we will create a new thread pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
