FMX commented on code in PR #2579:
URL: https://github.com/apache/celeborn/pull/2579#discussion_r1686033659
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/MapPartitionDataWriter.java:
##########
@@ -255,11 +261,10 @@ private void flushIndex() throws IOException {
while (indexBuffer.hasRemaining()) {
indexChannel.write(indexBuffer);
}
- } else if (diskFileInfo.isHdfs()) {
- FSDataOutputStream hdfsStream =
-
StorageManager.hadoopFs().append(diskFileInfo.getHdfsIndexPath());
- hdfsStream.write(indexBuffer.array());
- hdfsStream.close();
+ } else if (diskFileInfo.isDFS()) {
+ FSDataOutputStream dfsStream =
hadoopFs.append(diskFileInfo.getDfsIndexPath());
Review Comment:
Is this safe for S3? As far as I know, S3 doesn't support append.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
