zhaohehuhu commented on code in PR #2579:
URL: https://github.com/apache/celeborn/pull/2579#discussion_r1698193932
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/FlushTask.scala:
##########
@@ -55,3 +56,31 @@ private[worker] class HdfsFlushTask(
hdfsStream.close()
}
}
+
+private[worker] class S3FlushTask(
+ buffer: CompositeByteBuf,
+ val path: Path,
+ notifier: FlushNotifier,
+ keepBuffer: Boolean) extends FlushTask(buffer, notifier, keepBuffer) {
+ override def flush(): Unit = {
+ if (StorageManager.hadoopFs.exists(path)) {
+ val conf = StorageManager.hadoopFs.getConf
Review Comment:
Correct. The current implementation is just a workaround to solve the
limitation that S3 doesn't support append mode. I'm figure out a better
solution to avoid copy-and-write. @maobaolong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
