s0nskar opened a new pull request, #2643:
URL: https://github.com/apache/celeborn/pull/2643
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
- Minor logging change in AppDiskUsageMetric which are not critical but
slightly bothering.
- Fixed UT's for AppDiskUsageMetric
### Why are the changes needed?
1. Current AppDiskUsageMetric UTs were like placeholder and just printing
the output. They were not testing/verifying anything.
2. Minor logging change with AppDiskUsageMetric.
- Comma formating was wrong
```
Snapshot start 2024-07-24T08:47:12.496 end 2024-07-24T08:57:12.497
Application application_1717149813731_19042841_2 used approximate 15.9 GiB
,Application application_1717149813731_19042841_1 used approximate 13.9 GiB
```
- We were printing an extra empty line after each summary.
```
211:20:24.339 [master-app-disk-usage-metrics-logger] INFO
org.apache.celeborn.common.meta.AppDiskUsageMetric - App Disk Usage Top50
Report
Snapshot start 2024-07-24T09:17:12.498 end 2024-07-24T09:27:12.498
Application application_XXX used approximate 14.5 GiB
Snapshot start 2024-07-24T08:17:12.495 end 2024-07-24T08:27:12.496
Application application_XXX used approximate 15.9 GiB
11:27:12.507 [master-app-disk-usage-metrics-logger] INFO
org.apache.celeborn.common.meta.AppDiskUsageMetric - App Disk Usage Top50
Report
Snapshot start 2024-07-24T09:17:12.498 end 2024-07-24T09:27:12.498
Application application_XXX used approximate 14.5 GiB
Snapshot start 2024-07-24T08:17:12.495 end 2024-07-24T08:27:12.496
Application application_XXX used approximate 15.9 GiB
```
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Fixed current UTs and verified from the logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
