s0nskar commented on code in PR #2643:
URL: https://github.com/apache/celeborn/pull/2643#discussion_r1690138414
##########
common/src/main/scala/org/apache/celeborn/common/meta/AppDiskUsageMetric.scala:
##########
@@ -143,13 +143,8 @@ class AppDiskUsageMetric(conf: CelebornConf) extends
Logging {
currentSnapShot.get().commit()
}
currentSnapShot.set(getNewSnapShot())
- val summaryStr = Some(summary()).map(str =>
- if (str != null && str.nonEmpty) {
- "\n" + str
- } else {
- str
- }).getOrElse("")
Review Comment:
These checks were not needed as we are already treating summary as scala
option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
