pan3793 commented on code in PR #2641: URL: https://github.com/apache/celeborn/pull/2641#discussion_r1690717976
########## openapi/openapi-client/README.md: ########## @@ -0,0 +1,10 @@ +# Celeborn OpenApi Client Review Comment: ```suggestion # Celeborn OpenAPI Client ``` ########## openapi/openapi-client/README.md: ########## @@ -0,0 +1,10 @@ +# Celeborn OpenApi Client + +To update the Openapi specification +- just update the specification under `openapi/openapi-client/src/main/openapi3/` and keep the schema definitions consistent between master and worker. +- Install JDK11 by whatever mechanism is appropriate for your system, and set that version to be the default Java version (e.g., by setting env variable JAVA_HOME) Review Comment: must be 11? does 17 or 21 work? ########## openapi/openapi-client/README.md: ########## @@ -0,0 +1,10 @@ +# Celeborn OpenApi Client + +To update the Openapi specification Review Comment: ```suggestion To update the OpenAPI specification ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
