turboFei commented on code in PR #2641: URL: https://github.com/apache/celeborn/pull/2641#discussion_r1692563387
########## openapi/openapi-client/README.md: ########## @@ -0,0 +1,10 @@ +# Celeborn OpenAPI Client + +To update the OpenAPI specification +- just update the specification under `openapi/openapi-client/src/main/openapi3/` and keep the schema definitions consistent between master and worker. +- Install JDK11+ by whatever mechanism is appropriate for your system, and set that version to be the default Java version (e.g., by setting env variable JAVA_HOME) +- run the following: + ```sh + build/mvn -pl openapi/openapi-client clean package -Popenapi-generate Review Comment: sure, we can support sbt as well, with jdk11+ and same openapi generator plugin version. ########## openapi/openapi-client/README.md: ########## @@ -0,0 +1,10 @@ +# Celeborn OpenAPI Client + +To update the OpenAPI specification +- just update the specification under `openapi/openapi-client/src/main/openapi3/` and keep the schema definitions consistent between master and worker. +- Install JDK11+ by whatever mechanism is appropriate for your system, and set that version to be the default Java version (e.g., by setting env variable JAVA_HOME) +- run the following: + ```sh + build/mvn -pl openapi/openapi-client clean package -Popenapi-generate Review Comment: sure, we can support sbt as well, with jdk11+ and same openapi generator plugin version. https://github.com/OpenAPITools/sbt-openapi-generator/releases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
