jiang13021 commented on code in PR #2639:
URL: https://github.com/apache/celeborn/pull/2639#discussion_r1694134039
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -855,7 +881,8 @@ class LifecycleManager(val appUniqueId: String, val conf:
CelebornConf) extends
s"unexpected! unknown appShuffleId $appShuffleId when checking
shuffle deterministic level"))
}
} else {
- shuffleIds.values.map(v => v._1).toSeq.reverse.find(isAllMaptaskEnd)
match {
+ shuffleIds.values.filter(v => !isBarrierStage || v._2).map(v =>
v._1).toSeq.reverse.find(
Review Comment:
Why is there a check for `!isBarrierStage` here? It seems that there is no
difference between the barrier stage and the indeterminate stage here. In other
words, do we need to do a special check for the indeterminate stage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
