mridulm commented on code in PR #2639:
URL: https://github.com/apache/celeborn/pull/2639#discussion_r1694609764
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -855,7 +881,8 @@ class LifecycleManager(val appUniqueId: String, val conf:
CelebornConf) extends
s"unexpected! unknown appShuffleId $appShuffleId when checking
shuffle deterministic level"))
}
} else {
- shuffleIds.values.map(v => v._1).toSeq.reverse.find(isAllMaptaskEnd)
match {
+ shuffleIds.values.filter(v => !isBarrierStage || v._2).map(v =>
v._1).toSeq.reverse.find(
Review Comment:
I agree, this should be fine - though I was minimizing the imapct of the
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
