SteNicholas commented on code in PR #2629:
URL: https://github.com/apache/celeborn/pull/2629#discussion_r1698267526
##########
common/src/main/java/org/apache/celeborn/common/client/MasterClient.java:
##########
@@ -37,36 +37,35 @@
import org.slf4j.LoggerFactory;
import org.apache.celeborn.common.CelebornConf;
-import org.apache.celeborn.common.protocol.RpcNameConstants;
import
org.apache.celeborn.common.protocol.message.ControlMessages.OneWayMessageResponse$;
import org.apache.celeborn.common.protocol.message.MasterRequestMessage;
import org.apache.celeborn.common.protocol.message.Message;
import org.apache.celeborn.common.rpc.*;
import org.apache.celeborn.common.util.ThreadUtils;
+import org.apache.celeborn.common.util.Utils;
public class MasterClient {
private static final Logger LOG =
LoggerFactory.getLogger(MasterClient.class);
private final RpcEnv rpcEnv;
- private final List<String> masterEndpoints;
- private final int maxRetries;
+ private final MasterEndpointResolver masterEndpointResolver;
+ private int maxRetries;
Review Comment:
```suggestion
private final int maxRetries;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
