SteNicholas commented on code in PR #2629:
URL: https://github.com/apache/celeborn/pull/2629#discussion_r1696714674
##########
common/src/test/scala/org/apache/celeborn/common/CelebornConfSuite.scala:
##########
@@ -453,4 +441,23 @@ class CelebornConfSuite extends CelebornFunSuite {
}
}
+ test("CELEBORN-1511: Test master endpoint resolver") {
+ val conf = new CelebornConf()
+
+ val validResolverClass =
"org.apache.celeborn.common.client.StaticMasterEndpointResolver"
+ val invalidResolverClass = "org.apache.celeborn.UnknownClass"
+
+ conf.set(MASTER_ENDPOINTS_RESOLVER.key, validResolverClass)
+ assert(conf.masterEndpointResolver == validResolverClass)
+
+ try {
Review Comment:
Could this replace try...catch block with `assertThrows`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
