cfmcgrady commented on code in PR #2663:
URL: https://github.com/apache/celeborn/pull/2663#discussion_r1704260606
##########
client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/HashBasedShuffleWriter.java:
##########
@@ -353,6 +351,15 @@ protected void mergeData(int partitionId, byte[] buffer,
int offset, int length)
writeMetrics.incBytesWritten(bytesWritten);
}
+ private void abort() throws IOException {
+ try {
+ dataPusher.waitOnTermination();
Review Comment:
stop immediately instead of wait on termination?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
