cxzl25 commented on code in PR #2663:
URL: https://github.com/apache/celeborn/pull/2663#discussion_r1719571440
##########
client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/HashBasedShuffleWriter.java:
##########
@@ -319,6 +317,15 @@ private void flushSendBuffer(int partitionId, byte[]
buffer, int size)
writeMetrics.incWriteTime(System.nanoTime() - start);
}
+ private void abort() throws IOException {
+ try {
+ dataPusher.waitOnTermination();
+ } catch (InterruptedException e) {
+ TaskInterruptedHelper.throwTaskKillException();
Review Comment:
> we do need abort even with `IOException`, right ?
Yes
> so that the IOException already raised will propagate
Now change to record the last IOException, call the abort method, and
finally throw IOException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
