SteNicholas commented on code in PR #2670:
URL: https://github.com/apache/celeborn/pull/2670#discussion_r1706914857
##########
service/src/main/java/org/apache/celeborn/server/common/service/config/DynamicConfigServiceFactory.java:
##########
@@ -32,12 +44,13 @@ public static ConfigService getConfigService(CelebornConf
celebornConf) throws I
if (_INSTANCE == null) {
synchronized (DynamicConfigServiceFactory.class) {
if (_INSTANCE == null) {
- String configStoreBackend =
celebornConf.dynamicConfigStoreBackend().get();
- if ("FS".equals(configStoreBackend)) {
- _INSTANCE = new FsConfigServiceImpl(celebornConf);
- } else {
- _INSTANCE = new DbConfigServiceImpl(celebornConf);
- }
+ String configStoreBackendName =
celebornConf.dynamicConfigStoreBackend().get();
+ String configStoreBackendClass =
+ dynamicConfigStoreBackendShortNames.getOrDefault(
Review Comment:
User could not add short name of the custom `ConfigService` implementation
in `dynamicConfigStoreBackendShortNames`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
