s0nskar commented on PR #2670: URL: https://github.com/apache/celeborn/pull/2670#issuecomment-2275079518
> the implementation of ConfigService could use getName interface to load the implementation instance instead of hard code in factory. @SteNicholas Trying to understand this comment better – I think for this will have to make getName() static method but abstract static does not work. The factory approach will also need a lot of abstraction IMO it is not necessary for this as we will only have couple of predefined names. Let me know if you think otherwise then i will try to make it work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
