akpatnam25 commented on code in PR #2669:
URL: https://github.com/apache/celeborn/pull/2669#discussion_r1707450593
##########
common/src/test/scala/org/apache/celeborn/common/util/PbSerDeUtilsTest.scala:
##########
@@ -101,6 +101,7 @@ class PbSerDeUtilsTest extends CelebornFunSuite {
1005,
diskInfos,
userResourceConsumption)
+ workerInfo1.networkLocation_$eq("/1")
Review Comment:
@SteNicholas I don't think we need an assert for network location, since it
serializes and deserializes, and then asserts both are same here:
https://github.com/apache/celeborn/blob/main/common/src/test/scala/org/apache/celeborn/common/util/PbSerDeUtilsTest.scala#L253-L260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
