Re: [PR] [CELEBORN-1549] Fix networkLocation persistence into Ratis [celeborn]

[via GitHub]

akpatnam25 commented on PR #2669:
URL: https://github.com/apache/celeborn/pull/2669#issuecomment-2277112859

   > <img alt="截屏2024-08-09 11 42 24" width="875" 
src="https://private-user-images.githubusercontent.com/4150993/356455896-73d10ba8-70cc-4f11-b435-d1b9ae6ceebc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjMxNzY3MzQsIm5iZiI6MTcyMzE3NjQzNCwicGF0aCI6Ii80MTUwOTkzLzM1NjQ1NTg5Ni03M2QxMGJhOC03MGNjLTRmMTEtYjQzNS1kMWI5YWU2Y2VlYmMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDlUMDQwNzE0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NGU3ZDI3NDMwNzE5ZDllOGZkNTI2MjI1MmRkNDZiZTk5YTQyYjgyNjE0NDcxYmQ0Y2Q0NDlhMTUzNTkzMWNkZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.kXjg-5zumgx_BSMN6Lm7fjYzRtVCMiPRkE4q_6clTb4";>
 
org.apache.celeborn.service.deploy.master.clustermeta.AbstractMetaManager#restoreMetaFromFile
   > Abstract meta manager will try to resolve workerinfos who are 
"DEFAULT_RACK".
   
   @FMX  yes that is correct. However, this can be something different based on 
what is passed in to the workerInfo from the workers (see this 
[PR](https://github.com/apache/celeborn/pull/2367)). If that resolution on the 
worker side does not take place, master can try to resolve when it restores the 
snapshot. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org