waitinfuture commented on code in PR #2688:
URL: https://github.com/apache/celeborn/pull/2688#discussion_r1718333008
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -70,6 +67,8 @@ final private[worker] class StorageManager(conf:
CelebornConf, workerSource: Abs
val hasS3Storage = conf.hasS3Storage
+ val diskReserveSize = conf.workerDiskReserveSize
Review Comment:
Seems we should use `min(conf.workerDiskReserveSize, (totalSpace *
diskReserveRatio.get` as `getMinimumUsableSize` does.
##########
common/src/main/scala/org/apache/celeborn/common/meta/DeviceInfo.scala:
##########
@@ -92,6 +92,10 @@ class DiskInfo(
this.storageType = storageType
}
+ def setConfiguredUsableSpace(configuredUsableSpace : Long): Unit = {
Review Comment:
No need to add this method since `configuredUsableSpace` is public var
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
