zaynt4606 commented on code in PR #2688:
URL: https://github.com/apache/celeborn/pull/2688#discussion_r1721197938
##########
tests/spark-it/src/test/scala/org/apache/celeborn/tests/spark/CelebornHashCheckDiskSuite.scala:
##########
@@ -91,9 +91,9 @@ class CelebornHashCheckDiskSuite extends SparkTestBase {
worker.storageManager.workingDirWriters.values().asScala.foreach { t =>
assert(t.size() === 0)
}
- // after shuffle key expired, diskInfo.actualUsableSpace will equal
capacity=1000
+ // after shuffle key expired, diskInfo.actualUsableSpace will equal
capacity=0
Review Comment:
I think u mean the `diskInfo.totalSpace` is not empty, cause the usableSpace
has to considering about the disk reserve size.
Maybe the UT here means the totalSpace, the usableSpace and the totalSpace
int the original code in this UT will both be configuredUsableSpace.
But whatever, the UT here has nothing to do with this PR.
Is it fine that I change this condition into `diskInfo.totalSpace === 1000` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
