waitinfuture commented on code in PR #2663:
URL: https://github.com/apache/celeborn/pull/2663#discussion_r1723429257
##########
client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/HashBasedShuffleWriter.java:
##########
@@ -319,6 +320,17 @@ private void flushSendBuffer(int partitionId, byte[]
buffer, int size)
writeMetrics.incWriteTime(System.nanoTime() - start);
}
+ private void abort(boolean throwTaskKilledOnInterruption) throws IOException
{
Review Comment:
since `abort` is always called with `false`, IMO we don't need
`throwTaskKilledOnInterruption` here.
##########
client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SortBasedShuffleWriter.java:
##########
@@ -291,11 +296,17 @@ private void pushGiantRecord(int partitionId, byte[]
buffer, int numBytes) throw
writeMetrics.incBytesWritten(bytesWritten);
}
+ private void abort(boolean throwTaskKilledOnInterruption) throws IOException
{
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
