SteNicholas commented on code in PR #2719:
URL: https://github.com/apache/celeborn/pull/2719#discussion_r1744935667
##########
client/src/main/scala/org/apache/celeborn/client/ChangePartitionManager.scala:
##########
@@ -324,6 +330,8 @@ class ChangePartitionManager(
s"shuffle $shuffleId, succeed partitions: " +
s"$changes.")
}
+
+ // todo: should record the new partition locations and acknowledge
the new partitionLocations to downstream task, in scenario the downstream task
start early before the upstream task
Review Comment:
```suggestion
// TODO: should record the new partition locations and acknowledge
the new partitionLocations to downstream task, in scenario the downstream task
start early before the upstream task
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
