RexXiong commented on code in PR #2719:
URL: https://github.com/apache/celeborn/pull/2719#discussion_r1751318325
##########
client/src/main/scala/org/apache/celeborn/client/ChangePartitionManager.scala:
##########
@@ -165,6 +168,7 @@ class ChangePartitionManager(
// check if there exists request for the partition, if do just register
val requests = changePartitionRequests.computeIfAbsent(shuffleId,
rpcContextRegisterFunc)
inBatchPartitions.computeIfAbsent(shuffleId, inBatchShuffleIdRegisterFunc)
+ shuffleIsSegmentGranularityVisible.put(shuffleId,
isSegmentGranularityVisible)
Review Comment:
I believe the ChangePartitionManager can directly call
lifecycleManager.commitManager.isSegmentGranularityVisible to avoid redundant
metadata in memory. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
