leixm commented on PR #2725:
URL: https://github.com/apache/celeborn/pull/2725#issuecomment-2333069751

   > I suggest do this:
   > 
   > 1. do not call `totalInflightReqs.reset();` in 
`InFlightRequestTracker.cleanup`
   > 2. check `mapperEnd` in `limitZeroInFlight` and return true immediately if 
already ended
   > 3. check `mapperEnd` in `pushMergedData` and return immediately if already 
ended
   > 
   > cc @RexXiong @AngersZhuuuu @FMX
   
   We can't just focus on limitZeroInFlight, but also limitMaxInFlight. cc 
@waitinfuture 
   
   
![image](https://github.com/user-attachments/assets/2cdbbb39-7095-436f-a45d-d8e788b0fe8b)
   
![image](https://github.com/user-attachments/assets/6aca9a27-3f0f-44c0-8ce9-b0e5c8c06716)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to