Re: [PR] [CELEBORN-1506][FOLLOWUP] InFlightRequestTracker should not reset totalInflightReqs for cleaning up to avoid negative totalInflightReqs for limitZeroInFlight [celeborn]

Thu, 05 Sep 2024 22:21:04 -0700 


waitinfuture commented on PR #2725:
URL: https://github.com/apache/celeborn/pull/2725#issuecomment-2333251664

   > > I suggest do this:
   > > 
   > > 1. do not call `totalInflightReqs.reset();` in 
`InFlightRequestTracker.cleanup`
   > > 2. check `mapperEnd` in `limitZeroInFlight` and return true immediately 
if already ended
   > > 3. check `mapperEnd` in `pushMergedData` and return immediately if 
already ended
   > > 
   > > cc @RexXiong @AngersZhuuuu @FMX
   > 
   > We can't just focus on limitZeroInFlight, but also limitMaxInFlight. cc 
@waitinfuture
   > 
   > 
![image](https://private-user-images.githubusercontent.com/31424839/365013728-2cdbbb39-7095-436f-a45d-d8e788b0fe8b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU2MDAwMTksIm5iZiI6MTcyNTU5OTcxOSwicGF0aCI6Ii8zMTQyNDgzOS8zNjUwMTM3MjgtMmNkYmJiMzktNzA5NS00MzZmLWE0NWQtZDhlNzg4YjBmZThiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA2VDA1MTUxOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZhNzdmYzY3NDAyODhlZTY5OGMyODEyNWY3NTc1ZjExMWUyZmNmZDFlMTBhN2EzZDgyNDlkYzRlYmQ4MjYzYWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.7pFyXcCEnCI3z51iwHFESRgO0vjw8fLgFbWlvO9Vk2E)
 
![image](https://private-user-images.githubusercontent.com/31424839/365014129-6aca9a27-3f0f-44c0-8ce9-b0e5c8c06716.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJp
 
c3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU2MDAwMTksIm5iZiI6MTcyNTU5OTcxOSwicGF0aCI6Ii8zMTQyNDgzOS8zNjUwMTQxMjktNmFjYTlhMjctM2YwZi00NGMwLThjZTktYjBlNWM4YzA2NzE2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA2VDA1MTUxOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk4NjBiMTg3YzYyM2RjY2UxZDk5YWYzMTcyNTM5NDYwNDc4M2ZmNTJiZjA2ZWQzY2YwMTJmZTkwNThjOWYzMGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.aoDWwtZyrMH3eiVcxVnvt8sEdy25z9x4U_H2aUoyGZs)
   
   Does your code contain this ? https://github.com/apache/celeborn/pull/2191


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to