SteNicholas commented on code in PR #2701:
URL: https://github.com/apache/celeborn/pull/2701#discussion_r1771049911
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1671,6 +1687,20 @@ class LifecycleManager(val appUniqueId: String, val
conf: CelebornConf) extends
}
}
+ private def batchRequestMasterUnregisterShuffles(message:
PbBatchUnregisterShuffles)
+ : PbBatchUnregisterShuffleResponses = {
+ try {
+ logInfo(s"AskSync UnregisterShuffle for ${message.getShuffleIdsList}")
Review Comment:
```suggestion
logInfo(s"AskSync BatchUnregisterShuffle for
${message.getShuffleIdsList}")
```
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1671,6 +1687,20 @@ class LifecycleManager(val appUniqueId: String, val
conf: CelebornConf) extends
}
}
+ private def batchRequestMasterUnregisterShuffles(message:
PbBatchUnregisterShuffles)
+ : PbBatchUnregisterShuffleResponses = {
+ try {
+ logInfo(s"AskSync UnregisterShuffle for ${message.getShuffleIdsList}")
+ masterClient.askSync[PbBatchUnregisterShuffleResponses](
+ message,
+ classOf[PbBatchUnregisterShuffleResponses])
+ } catch {
+ case e: Exception =>
+ logError(s"AskSync UnregisterShuffle for ${message.getShuffleIdsList}
failed.", e)
Review Comment:
```suggestion
logError(s"AskSync BatchUnregisterShuffle for
${message.getShuffleIdsList} failed.", e)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
