zaynt4606 commented on code in PR #2701:
URL: https://github.com/apache/celeborn/pull/2701#discussion_r1767179895


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4476,6 +4477,14 @@ object CelebornConf extends Logging {
       .booleanConf
       .createWithDefault(true)
 
+  val CLIENT_BATCH_REMOVE_EXPIRED_SHUFFLE: ConfigEntry[Boolean] =
+    
buildConf("celeborn.client.shuffle.batchHandleRemoveExpiredShuffles.enabled")
+      .categories("client")
+      .version("0.6.0")
+      .doc("This is an optimization on remove Expired Shuffles and it's true 
by default.")

Review Comment:
   Yes! Changed~



##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1042,6 +1042,7 @@ class CelebornConf(loadDefaults: Boolean) extends 
Cloneable with Logging with Se
   def batchHandleChangePartitionNumThreads: Int = 
get(CLIENT_BATCH_HANDLE_CHANGE_PARTITION_THREADS)
   def batchHandleChangePartitionRequestInterval: Long =
     get(CLIENT_BATCH_HANDLE_CHANGE_PARTITION_INTERVAL)
+  def batchHandleRemoveExpiredShuffles: Boolean = 
get(CLIENT_BATCH_REMOVE_EXPIRED_SHUFFLE)

Review Comment:
   Done~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to