RexXiong commented on code in PR #2839:
URL: https://github.com/apache/celeborn/pull/2839#discussion_r1810361548
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -64,7 +66,7 @@ public abstract class AbstractMetaManager implements
IMetadataHandler {
public final Map<String, Set<Integer>> registeredAppAndShuffles =
JavaUtils.newConcurrentHashMap();
public final Set<String> hostnameSet = ConcurrentHashMap.newKeySet();
- public final Set<WorkerInfo> workers = ConcurrentHashMap.newKeySet();
+ private final Map<Integer, WorkerInfo> workersMap =
JavaUtils.newConcurrentHashMap();
Review Comment:
If you choose the hash code as the key, you may encounter hash collisions.
@turboFei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
