FMX commented on code in PR #2839:
URL: https://github.com/apache/celeborn/pull/2839#discussion_r1816350929
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -64,17 +66,20 @@ public abstract class AbstractMetaManager implements
IMetadataHandler {
public final Map<String, Set<Integer>> registeredAppAndShuffles =
JavaUtils.newConcurrentHashMap();
public final Set<String> hostnameSet = ConcurrentHashMap.newKeySet();
- public final Set<WorkerInfo> workers = ConcurrentHashMap.newKeySet();
+ private final Map<String, WorkerInfo> workersMap =
JavaUtils.newConcurrentHashMap();
public final ConcurrentHashMap<WorkerInfo, Long> lostWorkers =
JavaUtils.newConcurrentHashMap();
Review Comment:
I have seen your changes. I think these four variables can be changes to use
String instead of WorkerInfo to be the key. But there is no need to do it in
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
