FMX commented on code in PR #2891:
URL: https://github.com/apache/celeborn/pull/2891#discussion_r1832602056
##########
common/src/main/proto/TransportMessages.proto:
##########
@@ -443,6 +443,7 @@ message PbHeartbeatFromApplication {
repeated PbWorkerInfo needCheckedWorkerList = 5;
bool shouldResponse = 6;
int64 shuffleFallbackCount = 7;
+ map<string, int64> shuffleFallbackCounts = 8;
Review Comment:
Looks weird to keep two variables of the same purpose. You can calculate the
total fallback count from the detailed fallback count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
