turboFei commented on code in PR #2891:
URL: https://github.com/apache/celeborn/pull/2891#discussion_r1833420646
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -210,7 +211,10 @@ class LifecycleManager(val appUniqueId: String, val conf:
CelebornConf) extends
appUniqueId,
conf,
masterClient,
- () => commitManager.commitMetrics() ->
shuffleFallbackCount.sumThenReset(),
+ () =>
+ commitManager.commitMetrics() -> (shuffleFallbackCount.sumThenReset(),
+ shuffleFallbackCounts.asScala.map(count =>
+ (count._1, new java.lang.Long(count._2.sumThenReset()))).toMap),
Review Comment:
need to exclude the keyPair that value is `0` to reduce the heart beat
message
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -210,7 +211,10 @@ class LifecycleManager(val appUniqueId: String, val conf:
CelebornConf) extends
appUniqueId,
conf,
masterClient,
- () => commitManager.commitMetrics() ->
shuffleFallbackCount.sumThenReset(),
+ () =>
+ commitManager.commitMetrics() -> (shuffleFallbackCount.sumThenReset(),
+ shuffleFallbackCounts.asScala.map(count =>
+ (count._1, new java.lang.Long(count._2.sumThenReset()))).toMap),
Review Comment:
need to exclude the keyPair that value is `0` to reduce the heart beat
message size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
